Chore/scoped registries improvements #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlouisse
requested review from
gerjanvangeest,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: 64d9048 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlouisse
force-pushed
the
chore/scoped-registries-improvements
branch
from
30204f5 to
5a3909d
Compare
Co-authored-by: aghArdeshir <[email protected]>
tlouisse
force-pushed
the
chore/scoped-registries-improvements
branch
from
5a3909d to
64d9048
Compare
okadurin
reviewed
Nov 12, 2024
| @@ -9,6 +9,7 @@ | |||
| "custom-elements-manifest": "npm run custom-elements-manifest --workspaces --if-present && node ./scripts/create-api-tables.mjs", | |||
| "debug": "web-test-runner --watch --config web-test-runner-chrome.config.mjs", | |||
| "debug:firefox": "web-test-runner --watch --config web-test-runner-firefox.config.mjs", | |||
| "debug:no-scoped-registries-polyfill": "npm run debug -- --no-scoped-registries-polyfill", | |||
There was a problem hiding this comment.
Should we add both with polyfill and without polyfill configs to test:browser so that the npm run test covers both cases? Or is it to be done in a separate PR in the future?
There was a problem hiding this comment.
I was thinking about that as well, but for now I kept it limited. Feel free to do a proposal in the future
okadurin
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): no registration of same class twice w/o scoped-registries polyfill
chore: allow tests to run w/o polyfill
chore: cleanup wtr config, add pkg script for running w/o polyfill